Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADFS tweaks #1538

Merged
merged 8 commits into from
May 29, 2024
Merged

ADFS tweaks #1538

merged 8 commits into from
May 29, 2024

Conversation

ptbrowne
Copy link
Collaborator

Goals

Polishing login via government ADFS. Each commit should be self explanatory.

  • Added variables to Gitlab
  • Removed old keycloak variables (must be done when PR is merged)

@vercel Vercel
Copy link

vercel bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 8:38am

@ptbrowne ptbrowne requested a review from adintegra May 28, 2024 16:22
@ptbrowne
Copy link
Collaborator Author

The build on Vercel is failing since Prisma schema sync tries to drop columns. I do not see those columns locally. Does it ring a bell @adintegra ?

⚠️ There might be data loss when applying the changes:
• You are about to drop the column created_at on the users table, which still contains 3 non-null values.
• You are about to drop the column updated_at on the users table, which still contains 3 non-null values.
Error: Use the --accept-data-loss flag to ignore the data loss warnings like yarn prisma db push --accept-data-loss
error Command failed with exit code 1.

adintegra
adintegra reviewed May 29, 2024
View reviewed changes
README.md Outdated
Comment on lines 245 to 246
We use Next-auth to integrate our application with Keycloak.
See https://next-auth.js.org/providers/keycloak for documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could drop references to Keycloak altogether.

Alternatively, we could keep them (including what we had before in the Locally section below) and explain the use of Keycloak as an identity provider. Obviously more effort, but potentially more useful to other users of the project.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I had forgotten this last mention. I removed it and pointed to the custom adfs provider. Thanks.

adintegra
adintegra approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@adintegra adintegra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – thanks! 🎉

@adintegra
Copy link
Contributor

@ptbrowne just saw your comment on the dropping of columns. The columns were added in the branch I created (but not yet merged) yesterday. I suspect the migration must have been run from the branch and caused the schema drift.

@ptbrowne ptbrowne mentioned this pull request May 29, 2024
Draft
2 tasks
@ptbrowne ptbrowne merged commit 051b459 into main May 29, 2024
5 of 6 checks passed
@ptbrowne ptbrowne deleted the feat/adfs branch May 29, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bprusinowski bprusinowski bprusinowski approved these changes

@adintegra adintegra adintegra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptbrowne @adintegra @bprusinowski